Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Delete TPV Bank Account #239

Merged
merged 7 commits into from
Oct 7, 2021
Merged

Conversation

ankitdas13
Copy link
Contributor

implement addAllowedPayer , deleteAllowedPayer function and update README

Copy link
Contributor

@HancilSequeira HancilSequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Entity.php Outdated
@@ -160,8 +160,10 @@ protected function getEntity()

public function fill($data)
{
$attributes = array();

$attributes = array();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitdas13 what is been changed here


public function deleteAllowedPayer($id)
{
$relativeUrl = $this->getEntityUrl() . $this->id . '/allowed_payers/'.$id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference between $this->id and $id



if(is_array($data))
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format this code properly

@HancilSequeira HancilSequeira merged commit 781d64c into master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants